Commit b3edde44 authored by Vincent Guittot's avatar Vincent Guittot Committed by Ingo Molnar
Browse files

cpufreq/schedutil: Use a fixed reference frequency 



cpuinfo.max_freq can change at runtime because of boost as an example. This
implies that the value could be different than the one that has been
used when computing the capacity of a CPU.

The new arch_scale_freq_ref() returns a fixed and coherent reference
frequency that can be used when computing a frequency based on utilization.

Use this arch_scale_freq_ref() when available and fallback to
policy otherwise.

Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Reviewed-by: default avatarDietmar Eggemann <dietmar.eggemann@arm.com>
Acked-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20231211104855.558096-4-vincent.guittot@linaro.org
parent 599457ba

kernel/sched/cpufreq_schedutil.c

+24 −2
Original line number Diff line number Diff line
@@ -114,6 +114,28 @@ static void sugov_deferred_update(struct sugov_policy *sg_policy) 
	}

}



/**

 * get_capacity_ref_freq - get the reference frequency that has been used to

 * correlate frequency and compute capacity for a given cpufreq policy. We use

 * the CPU managing it for the arch_scale_freq_ref() call in the function.

 * @policy: the cpufreq policy of the CPU in question.

 *

 * Return: the reference CPU frequency to compute a capacity.

 */

static __always_inline

unsigned long get_capacity_ref_freq(struct cpufreq_policy *policy)

{

	unsigned int freq = arch_scale_freq_ref(policy->cpu);



	if (freq)

		return freq;



	if (arch_scale_freq_invariant())

		return policy->cpuinfo.max_freq;



	return policy->cur;

}



/**

 * get_next_freq - Compute a new frequency for a given cpufreq policy.

 * @sg_policy: schedutil policy object to compute the new frequency for.
@@ -140,9 +162,9 @@ static unsigned int get_next_freq(struct sugov_policy *sg_policy, 
				  unsigned long util, unsigned long max)

{

	struct cpufreq_policy *policy = sg_policy->policy;

	unsigned int freq = arch_scale_freq_invariant() ?

				policy->cpuinfo.max_freq : policy->cur;

	unsigned int freq;



	freq = get_capacity_ref_freq(policy);

	freq = map_util_freq(util, freq, max);



	if (freq == sg_policy->cached_raw_freq && !sg_policy->need_freq_update)