Commit b402328a authored by SurajSonawane2415's avatar SurajSonawane2415 Committed by Jens Axboe
Browse files

block: Fix elevator_get_default() checking for NULL q->tag_set 



elevator_get_default() and elv_support_iosched() both check for whether
or not q->tag_set is non-NULL, however it's not possible for them to be
NULL. This messes up some static checkers, as the checking of tag_set
isn't consistent.

Remove the checks, which both simplifies the logic and avoids checker
errors.

Signed-off-by: default avatarSurajSonawane2415 <surajsonawane0215@gmail.com>
Link: https://lore.kernel.org/r/20241007111416.13814-1-surajsonawane0215@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6d6e54fc

block/elevator.c

+2 −2
Original line number Diff line number Diff line
@@ -551,7 +551,7 @@ EXPORT_SYMBOL_GPL(elv_unregister); 
static inline bool elv_support_iosched(struct request_queue *q)

{

	if (!queue_is_mq(q) ||

	    (q->tag_set && (q->tag_set->flags & BLK_MQ_F_NO_SCHED)))

	    (q->tag_set->flags & BLK_MQ_F_NO_SCHED))

		return false;

	return true;

}
@@ -562,7 +562,7 @@ static inline bool elv_support_iosched(struct request_queue *q) 
 */

static struct elevator_type *elevator_get_default(struct request_queue *q)

{

	if (q->tag_set && q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)

	if (q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)

		return NULL;



	if (q->nr_hw_queues != 1 &&