Commit b411638f authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

ipv4: Use nlmsg_payload in fib_frontend file 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250415-nlmsg_v2-v1-5-a1c75d493fd7@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7d82cc22

net/ipv4/fib_frontend.c

+2 −2
Original line number Diff line number Diff line
@@ -948,12 +948,12 @@ int ip_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh, 
	if (filter->rtnl_held)

		ASSERT_RTNL();



	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*rtm))) {

	rtm = nlmsg_payload(nlh, sizeof(*rtm));

	if (!rtm) {

		NL_SET_ERR_MSG(extack, "Invalid header for FIB dump request");

		return -EINVAL;

	}



	rtm = nlmsg_data(nlh);

	if (rtm->rtm_dst_len || rtm->rtm_src_len  || rtm->rtm_tos   ||

	    rtm->rtm_scope) {

		NL_SET_ERR_MSG(extack, "Invalid values in header for FIB dump request");