Commit b426b3ba authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: vx_core: Drop unused dev field 



The vx_core.dev field has never been set but referred incorrectly at
firmware loading.  Pass the proper device pointer from card->dev at
request_firmware(), and drop the unused dev field from vx_core, too.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-11-tiwai@suse.de
parent b5557ef9

include/sound/vx_core.h

+0 −1
Original line number Diff line number Diff line
@@ -155,7 +155,6 @@ struct vx_core { 
	unsigned int chip_status;

	unsigned int pcm_running;



	struct device *dev;

	struct snd_hwdep *hwdep;



	struct vx_rmh irq_rmh;	/* RMH used in interrupts */

sound/drivers/vx/vx_hwdep.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ int snd_vx_setup_firmware(struct vx_core *chip) 
		if (! fw_files[chip->type][i])

			continue;

		sprintf(path, "vx/%s", fw_files[chip->type][i]);

		if (request_firmware(&fw, path, chip->dev)) {

		if (request_firmware(&fw, path, chip->card->dev)) {

			snd_printk(KERN_ERR "vx: can't load firmware %s\n", path);

			return -ENOENT;

		}