Commit b4b1ddc9 authored by Lizhe's avatar Lizhe Committed by Viresh Kumar
Browse files

cpufreq: Make cpufreq_driver->exit() return void 



The cpufreq core doesn't check the return type of the exit() callback
and there is not much the core can do on failures at that point. Just
drop the returned value and make it return void.

Signed-off-by: default avatarLizhe <sensor1010@163.com>
[ Viresh: Reworked the patches to fix all missing changes together. ]
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> # Mediatek
Acked-by: Sudeep Holla <sudeep.holla@arm.com> # scpi, scmi, vexpress
Acked-by: Mario Limonciello <mario.limonciello@amd.com> # amd
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> # bmips
Acked-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Acked-by: Kevin Hilman <khilman@baylibre.com> # omap
parent dfd3e8b9

drivers/cpufreq/acpi-cpufreq.c

+1 −3
Original line number Diff line number Diff line
@@ -906,7 +906,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) 
	return result;

}



static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)

static void acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)

{

	struct acpi_cpufreq_data *data = policy->driver_data;
@@ -919,8 +919,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) 
	free_cpumask_var(data->freqdomain_cpus);

	kfree(policy->freq_table);

	kfree(data);



	return 0;

}



static int acpi_cpufreq_resume(struct cpufreq_policy *policy)

drivers/cpufreq/amd-pstate.c

+2 −5
Original line number Diff line number Diff line
@@ -983,7 +983,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) 
	return ret;

}



static int amd_pstate_cpu_exit(struct cpufreq_policy *policy)

static void amd_pstate_cpu_exit(struct cpufreq_policy *policy)

{

	struct amd_cpudata *cpudata = policy->driver_data;
@@ -991,8 +991,6 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) 
	freq_qos_remove_request(&cpudata->req[0]);

	policy->fast_switch_possible = false;

	kfree(cpudata);



	return 0;

}



static int amd_pstate_cpu_resume(struct cpufreq_policy *policy)
@@ -1439,7 +1437,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) 
	return ret;

}



static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)

static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)

{

	struct amd_cpudata *cpudata = policy->driver_data;
@@ -1449,7 +1447,6 @@ static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) 
	}



	pr_debug("CPU %d exiting\n", policy->cpu);

	return 0;

}



static void amd_pstate_epp_update_limit(struct cpufreq_policy *policy)

drivers/cpufreq/apple-soc-cpufreq.c

+1 −3
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy) 
	return ret;

}



static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy)

static void apple_soc_cpufreq_exit(struct cpufreq_policy *policy)

{

	struct apple_cpu_priv *priv = policy->driver_data;
@@ -313,8 +313,6 @@ static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) 
	dev_pm_opp_remove_all_dynamic(priv->cpu_dev);

	iounmap(priv->reg_base);

	kfree(priv);



	return 0;

}



static struct cpufreq_driver apple_soc_cpufreq_driver = {

drivers/cpufreq/bmips-cpufreq.c

+1 −3
Original line number Diff line number Diff line
@@ -121,11 +121,9 @@ static int bmips_cpufreq_target_index(struct cpufreq_policy *policy, 
	return 0;

}



static int bmips_cpufreq_exit(struct cpufreq_policy *policy)

static void bmips_cpufreq_exit(struct cpufreq_policy *policy)

{

	kfree(policy->freq_table);



	return 0;

}



static int bmips_cpufreq_init(struct cpufreq_policy *policy)

drivers/cpufreq/cppc_cpufreq.c

+1 −2
Original line number Diff line number Diff line
@@ -683,7 +683,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) 
	return ret;

}



static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy)

static void cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy)

{

	struct cppc_cpudata *cpu_data = policy->driver_data;

	struct cppc_perf_caps *caps = &cpu_data->perf_caps;
@@ -700,7 +700,6 @@ static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) 
			 caps->lowest_perf, cpu, ret);



	cppc_cpufreq_put_cpu_data(policy);

	return 0;

}



static inline u64 get_delta(u64 t1, u64 t0)