Commit b4b797d8 authored by Zhen Lei's avatar Zhen Lei Committed by Vlastimil Babka
Browse files

mm/slab: remove duplicate check in create_cache() 



The WARN_ON() check in static function create_cache() is done by its only
parent __kmem_cache_create_args() before calling it.
	if (... ||
	    WARN_ON(... ||
		    object_size - args->usersize < args->useroffset))
		args->usersize = args->useroffset = 0;
	...
	s = create_cache(cache_name, object_size, args, flags);

Therefore, the WARN_ON() check in create_cache() can be safely removed.

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
parent 1e4df185

mm/slab_common.c

+0 −3
Original line number Diff line number Diff line
@@ -222,9 +222,6 @@ static struct kmem_cache *create_cache(const char *name, 
	struct kmem_cache *s;

	int err;



	if (WARN_ON(args->useroffset + args->usersize > object_size))

		args->useroffset = args->usersize = 0;



	/* If a custom freelist pointer is requested make sure it's sane. */

	err = -EINVAL;

	if (args->use_freeptr_offset &&