Commit b5100b72 authored by Gal Pressman's avatar Gal Pressman Committed by Jakub Kicinski
Browse files

net/mlx5e: Use extack in get module eeprom by page callback 



In case of errors in get module eeprom by page, reflect it through
extack instead of a dmesg print.
While at it, make the messages more human friendly.

Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20240808055927.2059700-10-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9c4298b4

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

+4 −2
Original line number Diff line number Diff line
@@ -2015,8 +2015,10 @@ static int mlx5e_get_module_eeprom_by_page(struct net_device *netdev, 
		if (size_read == -EINVAL)

			return -EINVAL;

		if (size_read < 0) {

			netdev_err(priv->netdev, "%s: mlx5_query_module_eeprom_by_page failed:0x%x\n",

				   __func__, size_read);

			NL_SET_ERR_MSG_FMT_MOD(

				extack,

				"Query module eeprom by page failed, read %u bytes, err %d\n",

				i, size_read);

			return i;

		}