Commit b59b86c5 authored by Thadeu Lima de Souza Cascardo's avatar Thadeu Lima de Souza Cascardo Committed by Ping-Ke Shih
Browse files

wifi: rtlwifi: pci: wait for firmware loading before releasing memory 



At probe error path, the firmware loading work may have already been
queued. In such a case, it will try to access memory allocated by the probe
function, which is about to be released. In such paths, wait for the
firmware worker to finish before releasing memory.

Fixes: 3d86b930 ("rtlwifi: Fix PCI probe error path orphaned memory")
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241206173713.3222187-5-cascardo@igalia.com
parent e7ceefbf

drivers/net/wireless/realtek/rtlwifi/pci.c

+1 −0
Original line number Diff line number Diff line
@@ -2218,6 +2218,7 @@ int rtl_pci_probe(struct pci_dev *pdev, 
fail4:

	rtl_deinit_core(hw);

fail3:

	wait_for_completion(&rtlpriv->firmware_loading_complete);

	rtlpriv->cfg->ops->deinit_sw_vars(hw);



fail2: