Unverified Commit b6190c45 authored by Shengjiu Wang's avatar Shengjiu Wang Committed by Mark Brown
Browse files

ASoC: SOF: imx: Add SNDRV_PCM_INFO_BATCH flag 



The sof imx pcm device is a device which should support
double buffering.

Found this issue with pipewire. When there is no
SNDRV_PCM_INFO_BATCH flag in driver, the pipewire will
set headroom to be zero, and because sof pcm device
don't support residue report, when the latency setting
is small, the "delay" always larger than "target" in
alsa-pcm.c, that reading next period data is not
scheduled on time.

With SNDRV_PCM_INFO_BATCH flag in driver, the pipewire
will select a smaller period size for device, then
the task of reading next period data will be scheduled
on time.

Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1703669263-13832-1-git-send-email-shengjiu.wang@nxp.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f87b4402

sound/soc/sof/imx/imx8.c

+1 −0
Original line number Diff line number Diff line
@@ -603,6 +603,7 @@ static struct snd_sof_dsp_ops sof_imx8x_ops = { 
			SNDRV_PCM_INFO_MMAP_VALID |

			SNDRV_PCM_INFO_INTERLEAVED |

			SNDRV_PCM_INFO_PAUSE |

			SNDRV_PCM_INFO_BATCH |

			SNDRV_PCM_INFO_NO_PERIOD_WAKEUP

};

sound/soc/sof/imx/imx8m.c

+1 −0
Original line number Diff line number Diff line
@@ -472,6 +472,7 @@ static struct snd_sof_dsp_ops sof_imx8m_ops = { 
		SNDRV_PCM_INFO_MMAP_VALID |

		SNDRV_PCM_INFO_INTERLEAVED |

		SNDRV_PCM_INFO_PAUSE |

		SNDRV_PCM_INFO_BATCH |

		SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,

};

sound/soc/sof/imx/imx8ulp.c

+1 −0
Original line number Diff line number Diff line
@@ -463,6 +463,7 @@ static struct snd_sof_dsp_ops sof_imx8ulp_ops = { 
			SNDRV_PCM_INFO_MMAP_VALID |

			SNDRV_PCM_INFO_INTERLEAVED |

			SNDRV_PCM_INFO_PAUSE |

			SNDRV_PCM_INFO_BATCH |

			SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,



	/* PM */