Commit b6b03097 authored by Cosmin Ratiu's avatar Cosmin Ratiu Committed by Jakub Kicinski
Browse files

net/mlx5: Initialize events outside devlink lock 



Move event init/cleanup outside of mlx5_init_one() / mlx5_uninit_one()
and into the mlx5_mdev_init() / mlx5_mdev_uninit() functions.

By doing this, we avoid the events being reinitialized on devlink reload
and, more importantly, the events->sw_nh notifier chain becomes
available earlier in the init procedure, which will be used in
subsequent patches. This makes sense because the events struct is pure
software, independent of any HW details.

Signed-off-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: default avatarCarolina Jubran <cjubran@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1763325940-1231508-2-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent beabc06f

drivers/net/ethernet/mellanox/mlx5/core/main.c

+24 −10
Original line number Diff line number Diff line
@@ -1010,16 +1010,10 @@ static int mlx5_init_once(struct mlx5_core_dev *dev) 
		goto err_irq_cleanup;

	}



	err = mlx5_events_init(dev);

	if (err) {

		mlx5_core_err(dev, "failed to initialize events\n");

		goto err_eq_cleanup;

	}



	err = mlx5_fw_reset_init(dev);

	if (err) {

		mlx5_core_err(dev, "failed to initialize fw reset events\n");

		goto err_events_cleanup;

		goto err_eq_cleanup;

	}



	mlx5_cq_debugfs_init(dev);
@@ -1121,8 +1115,6 @@ static int mlx5_init_once(struct mlx5_core_dev *dev) 
	mlx5_cleanup_reserved_gids(dev);

	mlx5_cq_debugfs_cleanup(dev);

	mlx5_fw_reset_cleanup(dev);

err_events_cleanup:

	mlx5_events_cleanup(dev);

err_eq_cleanup:

	mlx5_eq_table_cleanup(dev);

err_irq_cleanup:
@@ -1155,7 +1147,6 @@ static void mlx5_cleanup_once(struct mlx5_core_dev *dev) 
	mlx5_cleanup_reserved_gids(dev);

	mlx5_cq_debugfs_cleanup(dev);

	mlx5_fw_reset_cleanup(dev);

	mlx5_events_cleanup(dev);

	mlx5_eq_table_cleanup(dev);

	mlx5_irq_table_cleanup(dev);

	mlx5_devcom_unregister_device(dev->priv.devc);
@@ -1833,6 +1824,24 @@ static int vhca_id_show(struct seq_file *file, void *priv) 


DEFINE_SHOW_ATTRIBUTE(vhca_id);



static int mlx5_notifiers_init(struct mlx5_core_dev *dev)

{

	int err;



	err = mlx5_events_init(dev);

	if (err) {

		mlx5_core_err(dev, "failed to initialize events\n");

		return err;

	}



	return 0;

}



static void mlx5_notifiers_cleanup(struct mlx5_core_dev *dev)

{

	mlx5_events_cleanup(dev);

}



int mlx5_mdev_init(struct mlx5_core_dev *dev, int profile_idx)

{

	struct mlx5_priv *priv = &dev->priv;
@@ -1888,6 +1897,10 @@ int mlx5_mdev_init(struct mlx5_core_dev *dev, int profile_idx) 
	if (err)

		goto err_hca_caps;



	err = mlx5_notifiers_init(dev);

	if (err)

		goto err_hca_caps;



	/* The conjunction of sw_vhca_id with sw_owner_id will be a global

	 * unique id per function which uses mlx5_core.

	 * Those values are supplied to FW as part of the init HCA command to
@@ -1930,6 +1943,7 @@ void mlx5_mdev_uninit(struct mlx5_core_dev *dev) 
	if (priv->sw_vhca_id > 0)

		ida_free(&sw_vhca_ida, dev->priv.sw_vhca_id);



	mlx5_notifiers_cleanup(dev);

	mlx5_hca_caps_free(dev);

	mlx5_adev_cleanup(dev);

	mlx5_pagealloc_cleanup(dev);