Commit b7571015 authored by Hans de Goede's avatar Hans de Goede Committed by Hans Verkuil
Browse files

media: ipu-bridge: Add DMI quirk for Dell XPS laptops with upside down sensors 



The Dell XPS 13 9350 and XPS 16 9640 both have an upside-down mounted
OV02C10 sensor. This rotation of 180° is reported in neither the SSDB nor
the _PLD for the sensor (both report a rotation of 0°).

Add a DMI quirk mechanism for upside-down sensors and add 2 initial entries
to the DMI quirk list for these 2 laptops.

Note the OV02C10 driver was originally developed on a XPS 16 9640 which
resulted in inverted vflip + hflip settings making it look like the sensor
was upright on the XPS 16 9640 and upside down elsewhere this has been
fixed in commit d5ebe3f7 ("media: ov02c10: Fix default vertical flip").
This makes this commit a regression fix since now the video is upside down
on these Dell XPS models where it was not before.

Fixes: d5ebe3f7 ("media: ov02c10: Fix default vertical flip")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarBryan O'Donoghue <bod@kernel.org>
Reviewed-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarHans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent 1d2e3b44

drivers/media/pci/intel/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ source "drivers/media/pci/intel/ivsc/Kconfig" 


config IPU_BRIDGE

	tristate "Intel IPU Bridge"

	depends on ACPI || COMPILE_TEST

	depends on ACPI

	depends on I2C

	help

	  The IPU bridge is a helper library for Intel IPU drivers to

drivers/media/pci/intel/ipu-bridge.c

+29 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
#include <acpi/acpi_bus.h>

#include <linux/cleanup.h>

#include <linux/device.h>

#include <linux/dmi.h>

#include <linux/i2c.h>

#include <linux/mei_cl_bus.h>

#include <linux/platform_device.h>
@@ -98,6 +99,28 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { 
	IPU_SENSOR_CONFIG("XMCC0003", 1, 321468000),

};



/*

 * DMI matches for laptops which have their sensor mounted upside-down

 * without reporting a rotation of 180° in neither the SSDB nor the _PLD.

 */

static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {

	{

		.matches = {

			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9350"),

		},

		.driver_data = "OVTI02C1",

	},

	{

		.matches = {

			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 16 9640"),

		},

		.driver_data = "OVTI02C1",

	},

	{} /* Terminating entry */

};



static const struct ipu_property_names prop_names = {

	.clock_frequency = "clock-frequency",

	.rotation = "rotation",
@@ -248,6 +271,12 @@ static int ipu_bridge_read_acpi_buffer(struct acpi_device *adev, char *id, 
static u32 ipu_bridge_parse_rotation(struct acpi_device *adev,

				     struct ipu_sensor_ssdb *ssdb)

{

	const struct dmi_system_id *dmi_id;



	dmi_id = dmi_first_match(upside_down_sensor_dmi_ids);

	if (dmi_id && acpi_dev_hid_match(adev, dmi_id->driver_data))

		return 180;



	switch (ssdb->degree) {

	case IPU_SENSOR_ROTATION_NORMAL:

		return 0;