Commit b783fc4d authored by Daniel J Blueman's avatar Daniel J Blueman Committed by Kent Overstreet
Browse files

bcachefs: Fix potential sleeping during mount 



During mount, bcachefs mount option processing may sleep while allocating a string buffer.

Fix this by reference counting in order to take the atomic path.

Signed-off-by: default avatarDaniel J Blueman <daniel@quora.org>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 06974968

fs/bcachefs/disk_groups.c

+2 −0
Original line number Diff line number Diff line
@@ -555,6 +555,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v) 
	case TARGET_DEV: {

		struct bch_dev *ca;



		out->atomic++;

		rcu_read_lock();

		ca = t.dev < c->sb.nr_devices

			? rcu_dereference(c->devs[t.dev])
@@ -570,6 +571,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v) 
		}



		rcu_read_unlock();

		out->atomic--;

		break;

	}

	case TARGET_GROUP: