Commit b8d70702 authored by Priyanka Dandamudi's avatar Priyanka Dandamudi Committed by Rodrigo Vivi
Browse files

drm/xe/xe_exec_queue: Add check for access counter granularity 



Add conditional check for access counter granularity.
This check will return -EINVAL if granularity is beyond 64M
which is a hardware limitation.

v2: Defined
XE_ACC_GRANULARITY_128K 0
XE_ACC_GRANULARITY_2M 1
XE_ACC_GRANULARITY_16M 2
XE_ACC_GRANULARITY_64M 3
as part of uAPI.
So, that user can also use it.(Oak)

v3: Move uAPI to proper location and give proper
documentation.(Brian, Oak)

Cc: Oak Zeng <oak.zeng@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
Signed-off-by: default avatarPriyanka Dandamudi <priyanka.dandamudi@intel.com>
Reviewed-by: default avatarOak Zeng <oak.zeng@intel.com>
Reviewed-by: default avatarOak Zeng <oak.zeng@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 65e95735

drivers/gpu/drm/xe/xe_exec_queue.c

+3 −0
Original line number Diff line number Diff line
@@ -393,6 +393,9 @@ static int exec_queue_set_acc_granularity(struct xe_device *xe, struct xe_exec_q 
	if (XE_IOCTL_DBG(xe, !xe->info.supports_usm))

		return -EINVAL;



	if (value > XE_ACC_GRANULARITY_64M)

		return -EINVAL;



	q->usm.acc_granularity = value;



	return 0;

include/uapi/drm/xe_drm.h

+14 −0
Original line number Diff line number Diff line
@@ -731,6 +731,20 @@ struct drm_xe_vm_bind { 
	__u64 reserved[2];

};



/* For use with XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY */



/* Monitor 128KB contiguous region with 4K sub-granularity */

#define XE_ACC_GRANULARITY_128K 0



/* Monitor 2MB contiguous region with 64KB sub-granularity */

#define XE_ACC_GRANULARITY_2M 1



/* Monitor 16MB contiguous region with 512KB sub-granularity */

#define XE_ACC_GRANULARITY_16M 2



/* Monitor 64MB contiguous region with 2M sub-granularity */

#define XE_ACC_GRANULARITY_64M 3



/**

 * struct drm_xe_exec_queue_set_property - exec queue set property

 *