Commit b9886853 authored Apr 01, 2025 by Mario Limonciello Committed by Rafael J. Wysocki Apr 07, 2025

ACPI: EC: Set ec_no_wakeup for Lenovo Go S



When AC adapter is unplugged or plugged in EC wakes from HW sleep but
APU doesn't enter back into HW sleep.

The reason this happens is that, when the APU exits HW sleep, the power
rails controlled by the EC will power up the TCON.  The TCON has a GPIO
that will be toggled at this time.  The GPIO is not marked as a wakeup
source, but the GPIO controller still has an unserviced interrupt.
Unserviced interrupts will block entering HW sleep again. Clearing the
GPIO doesn't help as the TCON continues to assert it until it's been
initialized by i2c-hid.

Fixing this would require TCON F/W changes and it's already broken in
the wild on production hardware.

To avoid triggering this issue add a quirk to avoid letting EC wake
up system at all.  The power button still works properly on this system.

Reported-by: Antheas Kapenekakis <lkml@antheas.dev>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3929
Link: https://github.com/bazzite-org/patchwork/commit/95b93b2852718ee1e808c72e6b1836da4a95fc63


Co-developed-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/20250401133858.1892077-1-superm1@kernel.org


[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 0af2f6be

drivers/acpi/ec.c

+28 −0

Original line number	Diff line number	Diff line
		@@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
		DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
		},
		},
		/*
		* Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
		* https://gitlab.freedesktop.org/drm/amd/-/issues/3929
		*/
		{
		.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
		DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
		}
		},
		{
		.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
		DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
		}
		},
		{
		.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
		DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
		}
		},
		{
		.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
		DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
		}
		},
		{ },
		};