Commit ba72f6c7 authored Feb 07, 2024 by Markus Schneider-Pargmann Committed by Marc Kleine-Budde Feb 12, 2024

can: m_can: Move hrtimer init to m_can_class_register



The hrtimer_init() is called in m_can_plat_probe() and the hrtimer
function is set in m_can_class_register(). For readability it is better
to keep these two together in m_can_class_register().

Cc: Judith Mendez <jm@ti.com>
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/all/20240207093220.2681425-3-msp@baylibre.com


Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent a163c576

drivers/net/can/m_can/m_can.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2070,8 +2070,12 @@ int m_can_class_register(struct m_can_classdev *cdev)
		goto clk_disable;
		}

		if (!cdev->net->irq)
		if (!cdev->net->irq) {
		dev_dbg(cdev->dev, "Polling enabled, initialize hrtimer");
		hrtimer_init(&cdev->hrtimer, CLOCK_MONOTONIC,
		HRTIMER_MODE_REL_PINNED);
		cdev->hrtimer.function = &hrtimer_callback;
		}

		ret = m_can_dev_setup(cdev);
		if (ret)

drivers/net/can/m_can/m_can_platform.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -109,10 +109,6 @@ static int m_can_plat_probe(struct platform_device *pdev)
		ret = irq;
		goto probe_fail;
		}
		} else {
		dev_dbg(mcan_class->dev, "Polling enabled, initialize hrtimer");
		hrtimer_init(&mcan_class->hrtimer, CLOCK_MONOTONIC,
		HRTIMER_MODE_REL_PINNED);
		}

		/* message ram could be shared */