Unverified Commit bb504b4d authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Christian Brauner
Browse files

lockref: remove count argument of lockref_init 



All users of lockref_init() now initialize the count to 1, so hardcode
that and remove the count argument.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Link: https://lore.kernel.org/r/20250130135624.1899988-4-agruenba@redhat.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 34ad6fa2

fs/dcache.c

+1 −1
Original line number Diff line number Diff line
@@ -1700,7 +1700,7 @@ static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name) 
	smp_store_release(&dentry->d_name.name, dname); /* ^^^ */



	dentry->d_flags = 0;

	lockref_init(&dentry->d_lockref, 1);

	lockref_init(&dentry->d_lockref);

	seqcount_spinlock_init(&dentry->d_seq, &dentry->d_lock);

	dentry->d_inode = NULL;

	dentry->d_parent = dentry;

fs/erofs/zdata.c

+1 −1
Original line number Diff line number Diff line
@@ -726,7 +726,7 @@ static int z_erofs_register_pcluster(struct z_erofs_frontend *fe) 
	if (IS_ERR(pcl))

		return PTR_ERR(pcl);



	lockref_init(&pcl->lockref, 1); /* one ref for this request */

	lockref_init(&pcl->lockref); /* one ref for this request */

	pcl->algorithmformat = map->m_algorithmformat;

	pcl->length = 0;

	pcl->partial = true;

fs/gfs2/glock.c

+1 −1
Original line number Diff line number Diff line
@@ -1201,7 +1201,7 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, 
	if (glops->go_instantiate)

		gl->gl_flags |= BIT(GLF_INSTANTIATE_NEEDED);

	gl->gl_name = name;

	lockref_init(&gl->gl_lockref, 1);

	lockref_init(&gl->gl_lockref);

	lockdep_set_subclass(&gl->gl_lockref.lock, glops->go_subclass);

	gl->gl_state = LM_ST_UNLOCKED;

	gl->gl_target = LM_ST_UNLOCKED;

fs/gfs2/quota.c

+1 −1
Original line number Diff line number Diff line
@@ -236,7 +236,7 @@ static struct gfs2_quota_data *qd_alloc(unsigned hash, struct gfs2_sbd *sdp, str 
		return NULL;



	qd->qd_sbd = sdp;

	lockref_init(&qd->qd_lockref, 1);

	lockref_init(&qd->qd_lockref);

	qd->qd_id = qid;

	qd->qd_slot = -1;

	INIT_LIST_HEAD(&qd->qd_lru);

include/linux/lockref.h

+4 −3
Original line number Diff line number Diff line
@@ -37,12 +37,13 @@ struct lockref { 
/**

 * lockref_init - Initialize a lockref

 * @lockref: pointer to lockref structure

 * @count: initial count

 *

 * Initializes @lockref->count to 1.

 */

static inline void lockref_init(struct lockref *lockref, unsigned int count)

static inline void lockref_init(struct lockref *lockref)

{

	spin_lock_init(&lockref->lock);

	lockref->count = count;

	lockref->count = 1;

}



void lockref_get(struct lockref *lockref);