Commit bccaf98c authored by Max Krummenacher's avatar Max Krummenacher Committed by Frank Li
Browse files

Revert "ARM: dts: imx: move nand related property under nand@0"



This reverts commit 8124b4a4.

The change introduced a regression: at least Colibri iMX6ULL and
Colibri iMX7 no longer boot with that commit applied, while they boot
again after reverting it.

Although this has only been verified on these two modules, the issue
is expected to affect all device trees using the gpmi-nand driver.

[    0.876938] Creating 5 MTD partitions on "gpmi-nand":
[    0.876974] 0x000000000000-0x000000080000 : "mx7-bcb"
[    0.879860] 0x000000080000-0x000000200000 : "u-boot1"
[    0.884761] 0x000000200000-0x000000380000 : "u-boot2"
[    0.886993] 0x000000380000-0x000000400000 : "u-boot-env"
[    0.894686] 0x000000400000-0x000020000000 : "ubi"
[    0.899054] gpmi-nand 33002000.nand-controller: driver registered.
...
[    0.960443] ubi0: default fastmap pool size: 200
[    0.960476] ubi0: default fastmap WL pool size: 100
[    0.960500] ubi0: attaching mtd4
[    1.636355] ubi0 error: scan_peb: bad image sequence number 1588722158 in PEB 4060, expected 1574791632
...
[    1.649889] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd4, error -22
[    1.650029] UBI error: cannot attach mtd4
...
[    1.670262] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,253)

Fixes: 8124b4a4 ("ARM: dts: imx: move nand related property under nand@0")
Signed-off-by: default avatarMax Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
parent b6c94c71
Loading
Loading
Loading
Loading
+1 −5
Original line number Diff line number Diff line
@@ -36,12 +36,8 @@ &clks {
&gpmi {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_gpmi_nand>;
	status = "okay";

	nand@0 {
		reg = <0>;
	nand-on-flash-bbt;
	};
	status = "okay";
};

&i2c3 {
+1 −5
Original line number Diff line number Diff line
@@ -172,12 +172,8 @@ eth_phy: ethernet-phy@0 {
&gpmi {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_gpmi_nand>;
	status = "okay";

	nand@0 {
		reg = <0>;
	nand-on-flash-bbt;
	};
	status = "okay";
};

&i2c1 {
+1 −5
Original line number Diff line number Diff line
@@ -102,12 +102,8 @@ ethphy: ethernet-phy@0 {
&gpmi {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_gpmi_nand>;
	status = "okay";

	nand@0 {
		reg = <0>;
	nand-on-flash-bbt;
	};
	status = "okay";
};

&i2c1 {
+1 −5
Original line number Diff line number Diff line
@@ -73,12 +73,8 @@ ethphy: ethernet-phy@3 {
&gpmi {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_gpmi_nand>;
	status = "disabled";

	nand@0 {
		reg = <0>;
	nand-on-flash-bbt;
	};
	status = "disabled";
};

&i2c3 {
+1 −5
Original line number Diff line number Diff line
@@ -260,14 +260,10 @@ fixed-link {
&gpmi {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_gpmi_nand>;
	nand-on-flash-bbt;
	#address-cells = <1>;
	#size-cells = <0>;
	status = "okay";

	nand@0 {
		reg = <0>;
		nand-on-flash-bbt;
	};
};

&i2c3 {
Loading