Commit bd07f751 authored by Henry Martin's avatar Henry Martin Committed by Jiri Kosina
Browse files

HID: uclogic: Add NULL check in uclogic_input_configured() 



devm_kasprintf() returns NULL when memory allocation fails. Currently,
uclogic_input_configured() does not check for this case, which results
in a NULL pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: dd613a4e ("HID: uclogic: Correct devm device reference for hidinput input_dev name")
Signed-off-by: default avatarHenry Martin <bsdhenrymartin@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent fd34bf79

drivers/hid/hid-uclogic-core.c

+4 −3
Original line number Diff line number Diff line
@@ -142,11 +142,12 @@ static int uclogic_input_configured(struct hid_device *hdev, 
			suffix = "System Control";

			break;

		}

	}



	if (suffix)

	} else {

		hi->input->name = devm_kasprintf(&hdev->dev, GFP_KERNEL,

						 "%s %s", hdev->name, suffix);

		if (!hi->input->name)

			return -ENOMEM;

	}



	return 0;

}