Commit bd1c959f authored by Dragan Simic's avatar Dragan Simic Committed by Heiko Stuebner
Browse files

arm64: dts: rockchip: Add avdd HDMI supplies to RockPro64 board dtsi 

Add missing "avdd-0v9-supply" and "avdd-1v8-supply" properties to the "hdmi"
node in the Pine64 RockPro64 board dtsi file.  To achieve this, also add the
associated "vcca_0v9" regulator that produces the 0.9 V supply, [1][2] which
hasn't been defined previously in the board dtsi file.

This also eliminates the following warnings from the kernel log:

  dwhdmi-rockchip ff940000.hdmi: supply avdd-0v9 not found, using dummy regulator
  dwhdmi-rockchip ff940000.hdmi: supply avdd-1v8 not found, using dummy regulator

There are no functional changes to the way board works with these additions,
because the "vcc1v8_dvp" and "vcca_0v9" regulators are always enabled, [1][2]
but these additions improve the accuracy of hardware description.

These changes apply to the both supported hardware revisions of the Pine64
RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2]

[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf



Fixes: e4f3fb49 ("arm64: dts: rockchip: add initial dts support for Rockpro64")
Cc: stable@vger.kernel.org
Suggested-by: default avatarDiederik de Haas <didi.debian@cknow.org>
Signed-off-by: default avatarDragan Simic <dsimic@manjaro.org>
Tested-by: default avatarDiederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/df3d7e8fe74ed5e727e085b18c395260537bb5ac.1740941097.git.dsimic@manjaro.org


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 43c854c6

arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi

+12 −0
Original line number Diff line number Diff line
@@ -227,6 +227,16 @@ vcc5v0_usb: regulator-vcc5v0-usb { 
		vin-supply = <&vcc12v_dcin>;

	};



	vcca_0v9: regulator-vcca-0v9 {

		compatible = "regulator-fixed";

		regulator-name = "vcca_0v9";

		regulator-always-on;

		regulator-boot-on;

		regulator-min-microvolt = <900000>;

		regulator-max-microvolt = <900000>;

		vin-supply = <&vcc3v3_sys>;

	};



	vdd_log: regulator-vdd-log {

		compatible = "pwm-regulator";

		pwms = <&pwm2 0 25000 1>;
@@ -312,6 +322,8 @@ &gmac { 
};



&hdmi {

	avdd-0v9-supply = <&vcca_0v9>;

	avdd-1v8-supply = <&vcc1v8_dvp>;

	ddc-i2c-bus = <&i2c3>;

	pinctrl-names = "default";

	pinctrl-0 = <&hdmi_cec>;