Commit bde66d2d authored by Niklas Neronin's avatar Niklas Neronin Committed by Greg Kroah-Hartman
Browse files

usb: xhci: remove obsolete sanity check debug messages 



Remove debug messages that served as sanity checks during the initial
implementation phase of underrun/overrun completion codes. These checks
are now unnecessary.

Instead, improve the default debug messages for underrun/overrun events,
so that they are consistent with the reset of the completion codes.

Signed-off-by: default avatarNiklas Neronin <niklas.neronin@linux.intel.com>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20240626124835.1023046-14-mathias.nyman@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 43061949

drivers/usb/host/xhci-ring.c

+2 −8
Original line number Diff line number Diff line
@@ -2719,18 +2719,12 @@ static int handle_tx_event(struct xhci_hcd *xhci, 
		 * a Ring Overrun Event for IN Isoch endpoint or Ring

		 * Underrun Event for OUT Isoch endpoint.

		 */

		xhci_dbg(xhci, "underrun event on endpoint\n");

		if (!list_empty(&ep_ring->td_list))

			xhci_dbg(xhci, "Underrun Event for slot %u ep %d still with TDs queued?\n",

				 slot_id, ep_index);

		xhci_dbg(xhci, "Underrun event on slot %u ep %u\n", slot_id, ep_index);

		if (ep->skip)

			break;

		return 0;

	case COMP_RING_OVERRUN:

		xhci_dbg(xhci, "overrun event on endpoint\n");

		if (!list_empty(&ep_ring->td_list))

			xhci_dbg(xhci, "Overrun Event for slot %u ep %d still with TDs queued?\n",

				 slot_id, ep_index);

		xhci_dbg(xhci, "Overrun event on slot %u ep %u\n", slot_id, ep_index);

		if (ep->skip)

			break;

		return 0;