Commit be521bf7 authored by Hans Verkuil's avatar Hans Verkuil
Browse files

media: pci: cx18: if cx == NULL, then don't use it. 



If the cx NULL pointer check is true, then it reports
an error with CX18_ERR, but that uses cx. Replace it with
pr_err.

Reported by smatch:

drivers/media/pci/cx18/cx18-mailbox.c:834 cx18_vapi() error: we previously assumed 'cx' could be null (see line 833)

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 65b8c8cb

drivers/media/pci/cx18/cx18-mailbox.c

+1 −1
Original line number Diff line number Diff line
@@ -831,7 +831,7 @@ int cx18_vapi(struct cx18 *cx, u32 cmd, int args, ...) 
	int i;



	if (cx == NULL) {

		CX18_ERR("cx == NULL (cmd=%x)\n", cmd);

		pr_err("cx == NULL (cmd=%x)\n", cmd);

		return 0;

	}

	if (args > MAX_MB_ARGUMENTS) {