Commit bfc6270a authored by Alison Schofield's avatar Alison Schofield Committed by Dave Jiang
Browse files

cxl/features: Remove the inline specifier from to_cxlfs() 



to_cxlfs() was declared 'inline' in the header but only defined in
drivers/cxl/core/features.c. This has worked because features.c was
the only file using the function and the definition happened to be
available in the same compilation unit.

However, in preparation for a second .c file using the header and
needing to call the function, the inline specifier became an issue.
Sparse flagged the declaration as invalid since 'inline' requires a
visible definition at the point of use.

Defining the function in the header was considered but rejected, as
it depends on internal symbols not visible at that level.

Remove the inline specifier to correct the linkage violation.

Signed-off-by: default avatarAlison Schofield <alison.schofield@intel.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarShiju Jose <shiju.jose@huawei.com>
Link: https://patch.msgid.link/20250521233625.1745849-1-alison.schofield@intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent b4432656

drivers/cxl/core/features.c

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ static bool is_cxl_feature_exclusive(struct cxl_feat_entry *entry) 
	return is_cxl_feature_exclusive_by_uuid(&entry->uuid);

}



inline struct cxl_features_state *to_cxlfs(struct cxl_dev_state *cxlds)

struct cxl_features_state *to_cxlfs(struct cxl_dev_state *cxlds)

{

	return cxlds->cxlfs;

}

include/cxl/features.h

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ struct cxl_features_state { 
struct cxl_mailbox;

struct cxl_memdev;

#ifdef CONFIG_CXL_FEATURES

inline struct cxl_features_state *to_cxlfs(struct cxl_dev_state *cxlds);

struct cxl_features_state *to_cxlfs(struct cxl_dev_state *cxlds);

int devm_cxl_setup_features(struct cxl_dev_state *cxlds);

int devm_cxl_setup_fwctl(struct device *host, struct cxl_memdev *cxlmd);

#else