Commit c0ef1446 authored by Ivan Vecera's avatar Ivan Vecera Committed by Jakub Kicinski
Browse files

devlink: Add support for u64 parameters 



Only 8, 16 and 32-bit integers are supported for numeric devlink
parameters. The subsequent patch adds support for DPLL clock ID
that is defined as 64-bit number. Add support for u64 parameter
type.

Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20250704182202.1641943-4-ivecera@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9f149c5d

include/net/devlink.h

+2 −0
Original line number Diff line number Diff line
@@ -425,6 +425,7 @@ enum devlink_param_type { 
	DEVLINK_PARAM_TYPE_U8 = DEVLINK_VAR_ATTR_TYPE_U8,

	DEVLINK_PARAM_TYPE_U16 = DEVLINK_VAR_ATTR_TYPE_U16,

	DEVLINK_PARAM_TYPE_U32 = DEVLINK_VAR_ATTR_TYPE_U32,

	DEVLINK_PARAM_TYPE_U64 = DEVLINK_VAR_ATTR_TYPE_U64,

	DEVLINK_PARAM_TYPE_STRING = DEVLINK_VAR_ATTR_TYPE_STRING,

	DEVLINK_PARAM_TYPE_BOOL = DEVLINK_VAR_ATTR_TYPE_FLAG,

};
@@ -433,6 +434,7 @@ union devlink_param_value { 
	u8 vu8;

	u16 vu16;

	u32 vu32;

	u64 vu64;

	char vstr[__DEVLINK_PARAM_MAX_STRING_VALUE];

	bool vbool;

};

net/devlink/param.c

+10 −0
Original line number Diff line number Diff line
@@ -200,6 +200,11 @@ devlink_nl_param_value_fill_one(struct sk_buff *msg, 
		if (nla_put_u32(msg, DEVLINK_ATTR_PARAM_VALUE_DATA, val.vu32))

			goto value_nest_cancel;

		break;

	case DEVLINK_PARAM_TYPE_U64:

		if (devlink_nl_put_u64(msg, DEVLINK_ATTR_PARAM_VALUE_DATA,

				       val.vu64))

			goto value_nest_cancel;

		break;

	case DEVLINK_PARAM_TYPE_STRING:

		if (nla_put_string(msg, DEVLINK_ATTR_PARAM_VALUE_DATA,

				   val.vstr))
@@ -434,6 +439,11 @@ devlink_param_value_get_from_info(const struct devlink_param *param, 
			return -EINVAL;

		value->vu32 = nla_get_u32(param_data);

		break;

	case DEVLINK_PARAM_TYPE_U64:

		if (nla_len(param_data) != sizeof(u64))

			return -EINVAL;

		value->vu64 = nla_get_u64(param_data);

		break;

	case DEVLINK_PARAM_TYPE_STRING:

		len = strnlen(nla_data(param_data), nla_len(param_data));

		if (len == nla_len(param_data) ||