Commit c1beda1c authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: gov_user_space: Use .trip_crossed() instead of .throttle() 



Notifying user space about trip points that have not been crossed is
not particularly useful, so modify the User Space governor to use the
.trip_crossed() callback, which is only invoked for trips that have been
crossed, instead of .throttle() that is invoked for all trips in a
thermal zone every time the zone is updated.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Acked-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent c98e2479

drivers/thermal/gov_user_space.c

+5 −5
Original line number Diff line number Diff line
@@ -26,11 +26,13 @@ static int user_space_bind(struct thermal_zone_device *tz) 
 * notify_user_space - Notifies user space about thermal events

 * @tz: thermal_zone_device

 * @trip: trip point

 * @crossed_up: whether or not the trip has been crossed on the way up

 *

 * This function notifies the user space through UEvents.

 */

static int notify_user_space(struct thermal_zone_device *tz,

			     const struct thermal_trip *trip)

static void notify_user_space(struct thermal_zone_device *tz,

			      const struct thermal_trip *trip,

			      bool crossed_up)

{

	char *thermal_prop[5];

	int i;
@@ -46,13 +48,11 @@ static int notify_user_space(struct thermal_zone_device *tz, 
	kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, thermal_prop);

	for (i = 0; i < 4; ++i)

		kfree(thermal_prop[i]);



	return 0;

}



static struct thermal_governor thermal_gov_user_space = {

	.name		= "user_space",

	.throttle	= notify_user_space,

	.trip_crossed	= notify_user_space,

	.bind_to_tz	= user_space_bind,

};

THERMAL_GOVERNOR_DECLARE(thermal_gov_user_space);