Commit c2a16269 authored by Jian Shen's avatar Jian Shen Committed by Paolo Abeni
Browse files

net: hns3: using the num_tqps in the vf driver to apply for resources 



Currently, hdev->htqp is allocated using hdev->num_tqps, and kinfo->tqp
is allocated using kinfo->num_tqps. However, kinfo->num_tqps is set to
min(new_tqps, hdev->num_tqps);  Therefore, kinfo->num_tqps may be smaller
than hdev->num_tqps, which causes some hdev->htqp[i] to remain
uninitialized in hclgevf_knic_setup().

Thus, this patch allocates hdev->htqp and kinfo->tqp using hdev->num_tqps,
ensuring that the lengths of hdev->htqp and kinfo->tqp are consistent
and that all elements are properly initialized.

Fixes: e2cb1dec ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251211023737.2327018-2-shaojijie@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2939203f

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+2 −2
Original line number Diff line number Diff line
@@ -368,12 +368,12 @@ static int hclgevf_knic_setup(struct hclgevf_dev *hdev) 
	new_tqps = kinfo->rss_size * num_tc;

	kinfo->num_tqps = min(new_tqps, hdev->num_tqps);



	kinfo->tqp = devm_kcalloc(&hdev->pdev->dev, kinfo->num_tqps,

	kinfo->tqp = devm_kcalloc(&hdev->pdev->dev, hdev->num_tqps,

				  sizeof(struct hnae3_queue *), GFP_KERNEL);

	if (!kinfo->tqp)

		return -ENOMEM;



	for (i = 0; i < kinfo->num_tqps; i++) {

	for (i = 0; i < hdev->num_tqps; i++) {

		hdev->htqp[i].q.handle = &hdev->nic;

		hdev->htqp[i].q.tqp_index = i;

		kinfo->tqp[i] = &hdev->htqp[i].q;