Commit c2d0b7da authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dpaa_eth: simplify dpaa_ioctl() 



phylink_mii_ioctl() handles multiple ioctls in addition to just
SIOCGMIIREG: SIOCGMIIPHY, SIOCSMIIREG. Don't filter these out.

Also, phylink can handle the case where net_dev->phydev is NULL (like
optical SFP module, fixed-link). Be like other drivers and let phylink
do so without any driver-side call filtering.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Acked-by: default avatarMadalin Bucur <madalin.bucur@oss.nxp.com>
Link: https://patch.msgid.link/20250508124753.1492742-4-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7bf23055

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

+1 −8
Original line number Diff line number Diff line
@@ -3139,16 +3139,9 @@ static int dpaa_hwtstamp_set(struct net_device *dev, 


static int dpaa_ioctl(struct net_device *net_dev, struct ifreq *rq, int cmd)

{

	int ret = -EINVAL;

	struct dpaa_priv *priv = netdev_priv(net_dev);



	if (cmd == SIOCGMIIREG) {

		if (net_dev->phydev)

			return phylink_mii_ioctl(priv->mac_dev->phylink, rq,

						 cmd);

	}



	return ret;

	return phylink_mii_ioctl(priv->mac_dev->phylink, rq, cmd);

}



static const struct net_device_ops dpaa_ops = {