Commit c3264118 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller 



Remove ODM_RT_ASSERT macro definition from include/odm_debug.h and
its one caller in hal/odm.c, as this debug code is against best
practice.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210731003937.68615-4-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6a658067

drivers/staging/r8188eu/hal/odm.c

+0 −1
Original line number Diff line number Diff line
@@ -1373,7 +1373,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate 
		LowRSSIThreshForRA += GoUpGap;

		break;

	default:

		ODM_RT_ASSERT(pDM_Odm, false, ("wrong rssi level setting %d !", *pRATRState));

		break;

	}

drivers/staging/r8188eu/include/odm_debug.h

+0 −9
Original line number Diff line number Diff line
@@ -96,15 +96,6 @@ 
		RT_PRINTK fmt;						\

	}



#define ODM_RT_ASSERT(pDM_Odm, expr, fmt)				\

	if (!(expr)) {							\

		DbgPrint( "Assertion failed! %s at ......\n", #expr);	\

		DbgPrint( "      ......%s,%s,line=%d\n", __FILE__,	\

			__func__, __LINE__);				\

		RT_PRINTK fmt;						\

		ASSERT(false);						\

	}



void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm);



#endif	/*  __ODM_DBG_H__ */