Commit c4b680ac authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Christoph Hellwig
Browse files

nvme: fix implicit bool to flags conversion 



nvme_map_user_request() takes flags as the last argument, but
nvme_uring_cmd_io() shoves a bool "vec" into it. It behaves as
expected because bool is converted to 0/1 and NVME_IOCTL_VEC is
defined as 1, but it's better to pass flags explicitly.

Fixes: 7b7fdb8e ("nvme: replace the "bool vec" arguments with flags in the ioctl path")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarAnuj Gupta <anuj20.g@samsung.com>
Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 10f4a7cd

drivers/nvme/host/ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ static int nvme_uring_cmd_io(struct nvme_ctrl *ctrl, struct nvme_ns *ns, 
	if (d.data_len) {

		ret = nvme_map_user_request(req, d.addr, d.data_len,

			nvme_to_user_ptr(d.metadata), d.metadata_len,

			map_iter, vec);

			map_iter, vec ? NVME_IOCTL_VEC : 0);

		if (ret)

			goto out_free_req;

	}