Commit c522093b authored by Alan Huang's avatar Alan Huang Committed by Kent Overstreet
Browse files

bcachefs: Fix memmove when move keys down 

The fix alone doesn't fix [1], but should be applied before debugging
that.

[1] https://syzkaller.appspot.com/bug?extid=38a0cbd267eff2d286ff



Signed-off-by: default avatarAlan Huang <mmpgouride@gmail.com>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 68aaa637

fs/bcachefs/btree_io.c

+1 −1
Original line number Diff line number Diff line
@@ -996,7 +996,7 @@ static int validate_bset_keys(struct bch_fs *c, struct btree *b, 
		}

got_good_key:

		le16_add_cpu(&i->u64s, -next_good_key);

		memmove_u64s_down(k, bkey_p_next(k), (u64 *) vstruct_end(i) - (u64 *) k);

		memmove_u64s_down(k, (u64 *) k + next_good_key, (u64 *) vstruct_end(i) - (u64 *) k);

		set_btree_node_need_rewrite(b);

	}

fsck_err: