Unverified Commit c5528214 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: wcd93xx-sdw: fix of_property_read_bool() warnings 



Using of_property_read_bool() for non-boolean properties has been
deprecated in favour of of_property_present() and since commit
c141ecc3 ("of: Warn when of_property_read_bool() is used on
non-boolean properties") this also generates a warning:

	OF: /soc@0/soundwire@3330000/wcd9380-tx@0,3: Read of boolean property 'qcom,tx-port-mapping' with a value.

Switch to using of_property_present() to look for "qcom,tx-port-mapping"
properties.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://patch.msgid.link/20250210132128.7734-1-johan+linaro@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e97d06cb

sound/soc/codecs/wcd937x-sdw.c

+1 −1
Original line number Diff line number Diff line
@@ -1028,7 +1028,7 @@ static int wcd9370_probe(struct sdw_slave *pdev, 
		return -ENOMEM;



	/* Port map index starts at 0, however the data port for this codec start at index 1 */

	if (of_property_read_bool(dev->of_node, "qcom,tx-port-mapping")) {

	if (of_property_present(dev->of_node, "qcom,tx-port-mapping")) {

		wcd->is_tx = true;

		ret = of_property_read_u32_array(dev->of_node, "qcom,tx-port-mapping",

						 &pdev->m_port_map[1],

sound/soc/codecs/wcd938x-sdw.c

+1 −1
Original line number Diff line number Diff line
@@ -1229,7 +1229,7 @@ static int wcd9380_probe(struct sdw_slave *pdev, 
	 * Port map index starts with 0, however the data port for this codec

	 * are from index 1

	 */

	if (of_property_read_bool(dev->of_node, "qcom,tx-port-mapping")) {

	if (of_property_present(dev->of_node, "qcom,tx-port-mapping")) {

		wcd->is_tx = true;

		ret = of_property_read_u32_array(dev->of_node, "qcom,tx-port-mapping",

						 &pdev->m_port_map[1],

sound/soc/codecs/wcd939x-sdw.c

+1 −1
Original line number Diff line number Diff line
@@ -1429,7 +1429,7 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id) 
	 * Port map index starts with 0, however the data port for this codec

	 * are from index 1

	 */

	if (of_property_read_bool(dev->of_node, "qcom,tx-port-mapping")) {

	if (of_property_present(dev->of_node, "qcom,tx-port-mapping")) {

		wcd->is_tx = true;

		ret = of_property_read_u32_array(dev->of_node,

						 "qcom,tx-port-mapping",