Commit c5705a2a authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Paolo Abeni
Browse files

Octeontx2-af: Fix missing error code in cgx_probe() 



When CGX fails mapping to NIX, set the error code to -ENODEV, currently
err is zero and that is treated as success path.

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aLAdlCg2_Yv7Y-3h@stanley.mountain/


Fixes: d280233f ("Octeontx2-af: Fix NIX X2P calibration failures")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251010204239.94237-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2616222e

drivers/net/ethernet/marvell/octeontx2/af/cgx.c

+1 −0
Original line number Diff line number Diff line
@@ -1981,6 +1981,7 @@ static int cgx_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	    !is_cgx_mapped_to_nix(pdev->subsystem_device, cgx->cgx_id)) {

		dev_notice(dev, "CGX %d not mapped to NIX, skipping probe\n",

			   cgx->cgx_id);

		err = -ENODEV;

		goto err_release_regions;

	}