Commit c5c4c8fb authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/bochs: Remove manual format test from fb_create 



An updated implementation of drm_gem_fb_create() already tests the
driver's planes for supported formats. [1] No need to duplicate this
test in bochs.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.9/source/drivers/gpu/drm/drm_gem_framebuffer_helper.c#L169

 # 1
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240902105546.792625-2-tzimmermann@suse.de
parent 8a8a3120

drivers/gpu/drm/tiny/bochs.c

+1 −12
Original line number Diff line number Diff line
@@ -511,19 +511,8 @@ static void bochs_connector_init(struct drm_device *dev) 
	}

}



static struct drm_framebuffer *

bochs_gem_fb_create(struct drm_device *dev, struct drm_file *file,

		    const struct drm_mode_fb_cmd2 *mode_cmd)

{

	if (mode_cmd->pixel_format != DRM_FORMAT_XRGB8888 &&

	    mode_cmd->pixel_format != DRM_FORMAT_BGRX8888)

		return ERR_PTR(-EINVAL);



	return drm_gem_fb_create(dev, file, mode_cmd);

}



static const struct drm_mode_config_funcs bochs_mode_funcs = {

	.fb_create = bochs_gem_fb_create,

	.fb_create = drm_gem_fb_create,

	.mode_valid = drm_vram_helper_mode_valid,

	.atomic_check = drm_atomic_helper_check,

	.atomic_commit = drm_atomic_helper_commit,