Unverified Commit c5dbf041 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Ilpo Järvinen
Browse files

platform/x86: hp-bioscfg: Simplify return check in hp_add_other_attributes() 



All cases in switch-case have a same goto on error, move the return
check out of the switch. This is a cleanup.

Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 7a3c36ee

drivers/platform/x86/hp/hp-bioscfg/bioscfg.c

+3 −5
Original line number Diff line number Diff line
@@ -630,21 +630,19 @@ static int hp_add_other_attributes(int attr_type) 
	switch (attr_type) {

	case HPWMI_SECURE_PLATFORM_TYPE:

		ret = hp_populate_secure_platform_data(attr_name_kobj);

		if (ret)

			goto err_other_attr_init;

		break;



	case HPWMI_SURE_START_TYPE:

		ret = hp_populate_sure_start_data(attr_name_kobj);

		if (ret)

			goto err_other_attr_init;

		break;



	default:

		ret = -EINVAL;

		goto err_other_attr_init;

	}



	if (ret)

		goto err_other_attr_init;



	mutex_unlock(&bioscfg_drv.mutex);

	return 0;