Commit c5e8f292 authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: remove duplicated metadata folio flag update in end_bbio_meta_read() 



In that function we call set_extent_buffer_uptodate() or
clear_extent_buffer_uptodate(), which will already update the uptodate
flag for all the involved extent buffer folios.

Thus there is no need to update the folio uptodate flags again.

Just remove the open-coded part.

Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 8be4cb04

fs/btrfs/extent_io.c

+0 −16
Original line number Diff line number Diff line
@@ -3505,10 +3505,7 @@ static void clear_extent_buffer_reading(struct extent_buffer *eb) 
static void end_bbio_meta_read(struct btrfs_bio *bbio)

{

	struct extent_buffer *eb = bbio->private;

	struct btrfs_fs_info *fs_info = eb->fs_info;

	bool uptodate = !bbio->bio.bi_status;

	struct folio_iter fi;

	u32 bio_offset = 0;



	/*

	 * If the extent buffer is marked UPTODATE before the read operation
@@ -3530,19 +3527,6 @@ static void end_bbio_meta_read(struct btrfs_bio *bbio) 
		set_bit(EXTENT_BUFFER_READ_ERR, &eb->bflags);

	}



	bio_for_each_folio_all(fi, &bbio->bio) {

		struct folio *folio = fi.folio;

		u64 start = eb->start + bio_offset;

		u32 len = fi.length;



		if (uptodate)

			btrfs_folio_set_uptodate(fs_info, folio, start, len);

		else

			btrfs_folio_clear_uptodate(fs_info, folio, start, len);



		bio_offset += len;

	}



	clear_extent_buffer_reading(eb);

	free_extent_buffer(eb);