Commit c60324fb authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Andrew Morton
Browse files

lib/stackdepot: lower the indentation in stack_depot_init 

stack_depot_init does most things inside an if check. Move them out and
use a goto statement instead.

No functional changes.

Link: https://lkml.kernel.org/r/8e382f1f0c352e4b2ad47326fec7782af961fe8e.1676063693.git.andreyknvl@google.com


Signed-off-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Reviewed-by: default avatarAlexander Potapenko <glider@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent df225c87

lib/stackdepot.c

+37 −33
Original line number Diff line number Diff line
@@ -165,11 +165,13 @@ int __init stack_depot_early_init(void) 
int stack_depot_init(void)

{

	static DEFINE_MUTEX(stack_depot_init_mutex);

	unsigned long entries;

	int ret = 0;



	mutex_lock(&stack_depot_init_mutex);

	if (!stack_depot_disabled && !stack_table) {

		unsigned long entries;



	if (stack_depot_disabled || stack_table)

		goto out_unlock;



	/*

	 * Similarly to stack_depot_early_init, use stack_hash_order
@@ -194,17 +196,19 @@ int stack_depot_init(void) 
	if (entries > 1UL << STACK_HASH_ORDER_MAX)

		entries = 1UL << STACK_HASH_ORDER_MAX;



		pr_info("allocating hash table of %lu entries via kvcalloc\n",

				entries);

	pr_info("allocating hash table of %lu entries via kvcalloc\n", entries);

	stack_table = kvcalloc(entries, sizeof(struct stack_record *), GFP_KERNEL);

	if (!stack_table) {

		pr_err("hash table allocation failed, disabling\n");

		stack_depot_disabled = true;

		ret = -ENOMEM;

		goto out_unlock;

	}

	stack_hash_mask = entries - 1;

	}



out_unlock:

	mutex_unlock(&stack_depot_init_mutex);



	return ret;

}

EXPORT_SYMBOL_GPL(stack_depot_init);