Commit c63da7d6 authored by Kees Cook's avatar Kees Cook Committed by Jakub Kicinski
Browse files

mlxsw: core: Annotate struct mlxsw_env with __counted_by 

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct mlxsw_env.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci



Cc: Petr Machata <petrm@nvidia.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/20230929180746.3005922-2-keescook@chromium.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0b7ed818

drivers/net/ethernet/mellanox/mlxsw/core_env.c

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ struct mlxsw_env { 
	u8 num_of_slots; /* Including the main board. */

	u8 max_eeprom_len; /* Maximum module EEPROM transaction length. */

	struct mutex line_cards_lock; /* Protects line cards. */

	struct mlxsw_env_line_card *line_cards[];

	struct mlxsw_env_line_card *line_cards[] __counted_by(num_of_slots);

};



static bool __mlxsw_env_linecard_is_active(struct mlxsw_env *mlxsw_env,