Commit c8a8df49 authored by Thorsten Blum's avatar Thorsten Blum Committed by Bjorn Andersson
Browse files

rpmsg: Use strscpy() instead of strscpy_pad() 



kzalloc() already zero-initializes the destination buffer, making
strscpy() sufficient for safely copying the name. The additional NUL-
padding performed by strscpy_pad() is unnecessary.

The size parameter is optional, and strscpy() automatically determines
the size of the destination buffer using sizeof() when the argument is
omitted. RPMSG_NAME_SIZE is equal to sizeof(rpdev->id.name) and can be
removed - remove it.

No functional changes intended.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250429104543.66927-2-thorsten.blum@linux.dev


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 214ae22e

drivers/rpmsg/qcom_glink_native.c

+1 −1
Original line number Diff line number Diff line
@@ -1663,7 +1663,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, 
		}



		rpdev->ept = &channel->ept;

		strscpy_pad(rpdev->id.name, name, RPMSG_NAME_SIZE);

		strscpy(rpdev->id.name, name);

		rpdev->src = RPMSG_ADDR_ANY;

		rpdev->dst = RPMSG_ADDR_ANY;

		rpdev->ops = &glink_device_ops;

drivers/rpmsg/qcom_smd.c

+1 −1
Original line number Diff line number Diff line
@@ -1089,7 +1089,7 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel) 


	/* Assign public information to the rpmsg_device */

	rpdev = &qsdev->rpdev;

	strscpy_pad(rpdev->id.name, channel->name, RPMSG_NAME_SIZE);

	strscpy(rpdev->id.name, channel->name);

	rpdev->src = RPMSG_ADDR_ANY;

	rpdev->dst = RPMSG_ADDR_ANY;