Commit c8b359dd authored by Vasiliy Kovalev's avatar Vasiliy Kovalev Committed by Amir Goldstein
Browse files

ovl: Filter invalid inodes with missing lookup function 



Add a check to the ovl_dentry_weird() function to prevent the
processing of directory inodes that lack the lookup function.
This is important because such inodes can cause errors in overlayfs
when passed to the lowerstack.

Reported-by: default avatar <syzbot+a8c9d476508bd14a90e5@syzkaller.appspotmail.com>
Link: https://syzkaller.appspot.com/bug?extid=a8c9d476508bd14a90e5


Suggested-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
Link: https://lore.kernel.org/linux-unionfs/CAJfpegvx-oS9XGuwpJx=Xe28_jzWx5eRo1y900_ZzWY+=gGzUg@mail.gmail.com/


Signed-off-by: default avatarVasiliy Kovalev <kovalev@altlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
parent d66907b5

fs/overlayfs/util.c

+3 −0
Original line number Diff line number Diff line
@@ -202,6 +202,9 @@ void ovl_dentry_init_flags(struct dentry *dentry, struct dentry *upperdentry, 


bool ovl_dentry_weird(struct dentry *dentry)

{

	if (!d_can_lookup(dentry) && !d_is_file(dentry) && !d_is_symlink(dentry))

		return true;



	return dentry->d_flags & (DCACHE_NEED_AUTOMOUNT |

				  DCACHE_MANAGE_TRANSIT |

				  DCACHE_OP_HASH |