Commit c8d81a43 authored by Salomon Dushimirimana's avatar Salomon Dushimirimana Committed by Martin K. Petersen
Browse files

scsi: pm8001: Use module param to set pcs event log severity 



The pm8001 driver sets pcs event log threshold very high which causes
most of the FW log messages to not be captured. Add a module parameter
to configure pcs event log severity with 3 (medium severity) as the
default.

Co-developed-by: default avatarBhavesh Jashnani <bjashnani@google.com>
Signed-off-by: default avatarBhavesh Jashnani <bjashnani@google.com>
Signed-off-by: default avatarSalomon Dushimirimana <salomondush@google.com>
Link: https://lore.kernel.org/r/20241016220944.370539-1-salomondush@google.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7670e74f

drivers/scsi/pm8001/pm8001_init.c

+4 −0
Original line number Diff line number Diff line
@@ -68,6 +68,10 @@ static bool pm8001_read_wwn = true; 
module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);

MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");



uint pcs_event_log_severity = 0x03;

module_param(pcs_event_log_severity, int, 0644);

MODULE_PARM_DESC(pcs_event_log_severity, "PCS event log severity level");



static struct scsi_transport_template *pm8001_stt;

static int pm8001_init_ccb_tag(struct pm8001_hba_info *);

drivers/scsi/pm8001/pm8001_sas.h

+2 −0
Original line number Diff line number Diff line
@@ -96,6 +96,8 @@ extern struct list_head hba_list; 
extern const struct pm8001_dispatch pm8001_8001_dispatch;

extern const struct pm8001_dispatch pm8001_80xx_dispatch;



extern uint pcs_event_log_severity;



struct pm8001_hba_info;

struct pm8001_ccb_info;

struct pm8001_device;

drivers/scsi/pm8001/pm80xx_hwi.c

+2 −1
Original line number Diff line number Diff line
@@ -763,7 +763,8 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) 
		pm8001_ha->memoryMap.region[IOP].phys_addr_lo;

	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_size		=

							PM8001_EVENT_LOG_SIZE;

	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity	= 0x01;

	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity	=

		pcs_event_log_severity;

	pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt		= 0x01;



	/* Enable higher IQs and OQs, 32 to 63, bit 16 */