Commit c8e88de1 authored by Dan Williams's avatar Dan Williams Committed by Dave Jiang
Browse files

ACPI/HMAT: Move HMAT messages to pr_debug() 



The HMAT messages printed at boot, beyond being noisy, can also print
details for nodes that are not yet enabled. The primary method to
consume HMAT details is via sysfs, and the sysfs interface gates what is
emitted by whether the node is online or not. Hide the messages by
default by moving them from "info" to "debug" log level.

Otherwise, these prints are just a pretty-print way to dump the ACPI
HMAT table. It has always been the case that post-analysis was required
for these messages to map proximity-domains to Linux NUMA nodes, and as
Priya points out that analysis also needs to consider whether the
proximity domain is marked "enabled" in the SRAT.

Reported-by: default avatarPriya Autee <priya.v.autee@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/170668982094.318782.2963631284830500182.stgit@dwillia2-xfh.jf.intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent fc033cf2

drivers/acpi/numa/hmat.c

+12 −12
Original line number Diff line number Diff line
@@ -442,7 +442,7 @@ static __init int hmat_parse_locality(union acpi_subtable_headers *header, 
		return -EINVAL;

	}



	pr_info("Locality: Flags:%02x Type:%s Initiator Domains:%u Target Domains:%u Base:%lld\n",

	pr_debug("Locality: Flags:%02x Type:%s Initiator Domains:%u Target Domains:%u Base:%lld\n",

		 hmat_loc->flags, hmat_data_type(type), ipds, tpds,

		 hmat_loc->entry_base_unit);
@@ -455,7 +455,7 @@ static __init int hmat_parse_locality(union acpi_subtable_headers *header, 
			value = hmat_normalize(entries[init * tpds + targ],

					       hmat_loc->entry_base_unit,

					       type);

			pr_info("  Initiator-Target[%u-%u]:%u%s\n",

			pr_debug("  Initiator-Target[%u-%u]:%u%s\n",

				 inits[init], targs[targ], value,

				 hmat_data_type_suffix(type));
@@ -485,7 +485,7 @@ static __init int hmat_parse_cache(union acpi_subtable_headers *header, 
	}



	attrs = cache->cache_attributes;

	pr_info("Cache: Domain:%u Size:%llu Attrs:%08x SMBIOS Handles:%d\n",

	pr_debug("Cache: Domain:%u Size:%llu Attrs:%08x SMBIOS Handles:%d\n",

		 cache->memory_PD, cache->cache_size, attrs,

		 cache->number_of_SMBIOShandles);
@@ -546,7 +546,7 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade 
	}



	if (hmat_revision == 1)

		pr_info("Memory (%#llx length %#llx) Flags:%04x Processor Domain:%u Memory Domain:%u\n",

		pr_debug("Memory (%#llx length %#llx) Flags:%04x Processor Domain:%u Memory Domain:%u\n",

			 p->reserved3, p->reserved4, p->flags, p->processor_PD,

			 p->memory_PD);

	else