Commit c8fee6a7 authored by Thomas Zimmermann's avatar Thomas Zimmermann Committed by Helge Deller
Browse files

fbdev: Make drivers depend on LCD_CLASS_DEVICE 



LCD_CLASS_DEVICE is the user-controlled option that enables the LCD
display subsystem. Do not select it from fbdev drivers. Selecting it
from drivers can lead to cyclic dependencies within the config.

Some guidelines for using select can be found in the kernel docs at [1].

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147

 # [1]
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent c3073f1d

drivers/video/fbdev/Kconfig

+2 −2
Original line number Diff line number Diff line
@@ -126,9 +126,9 @@ config FB_ACORN 
config FB_CLPS711X

	tristate "CLPS711X LCD support"

	depends on FB && (ARCH_CLPS711X || COMPILE_TEST)

	depends on LCD_CLASS_DEVICE

	select FB_IOMEM_HELPERS

	select FB_MODE_HELPERS

	select LCD_CLASS_DEVICE

	select VIDEOMODE_HELPERS

	help

	  Say Y to enable the Framebuffer driver for the Cirrus Logic
@@ -150,7 +150,7 @@ config FB_IMX 
	tristate "Freescale i.MX1/21/25/27 LCD support"

	depends on FB && HAVE_CLK && HAS_IOMEM

	depends on ARCH_MXC || COMPILE_TEST

	select LCD_CLASS_DEVICE

	depends on LCD_CLASS_DEVICE

	select FB_IOMEM_HELPERS

	select FB_MODE_HELPERS

	select VIDEOMODE_HELPERS