Commit c994cb59 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: fix gpio-based orientation detection 



Fix the recently added connector sanity check which was off by one and
prevented orientation notifications from being handled correctly for the
second port when using GPIOs to determine orientation.

Fixes: c6165ed2 ("usb: ucsi: glink: use the connector orientation GPIO to provide switch events")
Cc: stable <stable@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20231208123603.29957-1-johan+linaro@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aef05e34

drivers/usb/typec/ucsi/ucsi_glink.c

+1 −1
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ static void pmic_glink_ucsi_notify(struct work_struct *work) 


	con_num = UCSI_CCI_CONNECTOR(cci);

	if (con_num) {

		if (con_num < PMIC_GLINK_MAX_PORTS &&

		if (con_num <= PMIC_GLINK_MAX_PORTS &&

		    ucsi->port_orientation[con_num - 1]) {

			int orientation = gpiod_get_value(ucsi->port_orientation[con_num - 1]);