Commit c9c99b7b authored by Jian Zhang's avatar Jian Zhang Committed by Corey Minyard
Browse files

ipmi: ssif_bmc: change log level to dbg in irq callback 



Long-running tests indicate that this logging can occasionally disrupt
timing and lead to request/response corruption.

Irq handler need to be executed as fast as possible,
most I2C slave IRQ implementations are byte-level, logging here
can significantly affect transfer behavior and timing. It is recommended
to use dev_dbg() for these messages.

Fixes: dd2bc5cc ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by: default avatarJian Zhang <zhangjian.3032@bytedance.com>
Message-ID: <20260403090603.3988423-4-zhangjian.3032@bytedance.com>
Signed-off-by: default avatarCorey Minyard <corey@minyard.net>
parent 1d38e849

drivers/char/ipmi/ssif_bmc.c

+9 −9
Original line number Diff line number Diff line
@@ -569,7 +569,7 @@ static void process_request_part(struct ssif_bmc_ctx *ssif_bmc) 
		len = ssif_bmc->request.len + part->length;

		/* Do the bound check here, not allow the request len exceed 254 bytes */

		if (len > IPMI_SSIF_PAYLOAD_MAX) {

			dev_warn(&ssif_bmc->client->dev,

			dev_dbg(&ssif_bmc->client->dev,

				 "Warn: Request exceeded 254 bytes, aborting");

			/* Request too long, aborting */

			ssif_bmc->aborting =  true;
@@ -615,7 +615,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 
	    ssif_bmc->state == SSIF_START ||

	    ssif_bmc->state == SSIF_REQ_RECVING ||

	    ssif_bmc->state == SSIF_RES_SENDING) {

		dev_warn(&ssif_bmc->client->dev,

		dev_dbg(&ssif_bmc->client->dev,

			 "Warn: %s unexpected READ REQUESTED in state=%s\n",

			 __func__, state_to_string(ssif_bmc->state));

		ssif_bmc->state = SSIF_ABORTING;
@@ -624,7 +624,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 


	} else if (ssif_bmc->state == SSIF_SMBUS_CMD) {

		if (!supported_read_cmd(ssif_bmc->part_buf.smbus_cmd)) {

			dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x",

			dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x",

				 ssif_bmc->part_buf.smbus_cmd);

			ssif_bmc->aborting = true;

		}
@@ -659,7 +659,7 @@ static void on_read_processed_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 
	    ssif_bmc->state == SSIF_START ||

	    ssif_bmc->state == SSIF_REQ_RECVING ||

	    ssif_bmc->state == SSIF_SMBUS_CMD) {

		dev_warn(&ssif_bmc->client->dev,

		dev_dbg(&ssif_bmc->client->dev,

			 "Warn: %s unexpected READ PROCESSED in state=%s\n",

			 __func__, state_to_string(ssif_bmc->state));

		ssif_bmc->state = SSIF_ABORTING;
@@ -684,7 +684,7 @@ static void on_write_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 
	} else if (ssif_bmc->state == SSIF_START ||

		   ssif_bmc->state == SSIF_REQ_RECVING ||

		   ssif_bmc->state == SSIF_RES_SENDING) {

		dev_warn(&ssif_bmc->client->dev,

		dev_dbg(&ssif_bmc->client->dev,

			 "Warn: %s unexpected WRITE REQUEST in state=%s\n",

			 __func__, state_to_string(ssif_bmc->state));

		ssif_bmc->state = SSIF_ABORTING;
@@ -699,7 +699,7 @@ static void on_write_received_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 
{

	if (ssif_bmc->state == SSIF_READY ||

	    ssif_bmc->state == SSIF_RES_SENDING) {

		dev_warn(&ssif_bmc->client->dev,

		dev_dbg(&ssif_bmc->client->dev,

			 "Warn: %s unexpected WRITE RECEIVED in state=%s\n",

			 __func__, state_to_string(ssif_bmc->state));

		ssif_bmc->state = SSIF_ABORTING;
@@ -709,7 +709,7 @@ static void on_write_received_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 


	} else if (ssif_bmc->state == SSIF_SMBUS_CMD) {

		if (!supported_write_cmd(ssif_bmc->part_buf.smbus_cmd)) {

			dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x",

			dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x",

				 ssif_bmc->part_buf.smbus_cmd);

			ssif_bmc->aborting = true;

		}
@@ -738,7 +738,7 @@ static void on_stop_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) 
	    ssif_bmc->state == SSIF_START ||

	    ssif_bmc->state == SSIF_SMBUS_CMD ||

	    ssif_bmc->state == SSIF_ABORTING) {

		dev_warn(&ssif_bmc->client->dev,

		dev_dbg(&ssif_bmc->client->dev,

			 "Warn: %s unexpected SLAVE STOP in state=%s\n",

			 __func__, state_to_string(ssif_bmc->state));

		ssif_bmc->state = SSIF_READY;
@@ -805,7 +805,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum i2c_slave_event event, u8 
		break;



	default:

		dev_warn(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n");

		dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n");

		break;

	}