Commit c9ccb88f authored by H. Nikolaus Schaller's avatar H. Nikolaus Schaller Committed by Dmitry Torokhov
Browse files

Input: ads7846 - fix gpiod allocation 



commit 767d8336 ("Input: ads7846 - Convert to use software nodes")

has simplified the code but accidentially converted a devm_gpiod_get()
to gpiod_get(). This leaves the gpio reserved on module remove and the
driver can no longer be loaded again.

Fixes: 767d8336 ("Input: ads7846 - Convert to use software nodes")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
Link: https://lore.kernel.org/r/6e9b143f19cdfda835711a8a7a3966e5a2494cff.1738410204.git.hns@goldelico.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent c8084a89

drivers/input/touchscreen/ads7846.c

+1 −1
Original line number Diff line number Diff line
@@ -1021,7 +1021,7 @@ static int ads7846_setup_pendown(struct spi_device *spi, 
	if (pdata->get_pendown_state) {

		ts->get_pendown_state = pdata->get_pendown_state;

	} else {

		ts->gpio_pendown = gpiod_get(&spi->dev, "pendown", GPIOD_IN);

		ts->gpio_pendown = devm_gpiod_get(&spi->dev, "pendown", GPIOD_IN);

		if (IS_ERR(ts->gpio_pendown)) {

			dev_err(&spi->dev, "failed to request pendown GPIO\n");

			return PTR_ERR(ts->gpio_pendown);