Commit c9d81578 authored by Johannes Berg's avatar Johannes Berg Committed by Miri Korenblit
Browse files

wifi: iwlwifi: pcie: log async commands 



Currently, there are two log messages at INFO level for
synchronous commands:

    Attempting to send sync command ...
    Setting HCMD_ACTIVE for command ...

and unfortunately none at all for async ones. Add one
for async commands as well.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20250505215512.cc4457285889.I633fae8828e8a37bbebc578166f388dcf893f592@changeid


Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
parent befaea30

drivers/net/wireless/intel/iwlwifi/pcie/tx.c

+7 −3
Original line number Diff line number Diff line
@@ -2549,10 +2549,10 @@ void iwl_pcie_freeze_txq_timer(struct iwl_trans *trans, 
#define HOST_COMPLETE_TIMEOUT	(2 * HZ)



static int iwl_trans_pcie_send_hcmd_sync(struct iwl_trans *trans,

					 struct iwl_host_cmd *cmd)

					 struct iwl_host_cmd *cmd,

					 const char *cmd_str)

{

	struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);

	const char *cmd_str = iwl_get_cmd_string(trans, cmd->id);

	struct iwl_txq *txq = trans_pcie->txqs.txq[trans->conf.cmd_queue];

	int cmd_idx;

	int ret;
@@ -2646,6 +2646,8 @@ static int iwl_trans_pcie_send_hcmd_sync(struct iwl_trans *trans, 
int iwl_trans_pcie_send_hcmd(struct iwl_trans *trans,

			     struct iwl_host_cmd *cmd)

{

	const char *cmd_str = iwl_get_cmd_string(trans, cmd->id);



	/* Make sure the NIC is still alive in the bus */

	if (test_bit(STATUS_TRANS_DEAD, &trans->status))

		return -ENODEV;
@@ -2660,6 +2662,8 @@ int iwl_trans_pcie_send_hcmd(struct iwl_trans *trans, 
	if (cmd->flags & CMD_ASYNC) {

		int ret;



		IWL_DEBUG_INFO(trans, "Sending async command %s\n", cmd_str);



		/* An asynchronous command can not expect an SKB to be set. */

		if (WARN_ON(cmd->flags & CMD_WANT_SKB))

			return -EINVAL;
@@ -2678,5 +2682,5 @@ int iwl_trans_pcie_send_hcmd(struct iwl_trans *trans, 
		return 0;

	}



	return iwl_trans_pcie_send_hcmd_sync(trans, cmd);

	return iwl_trans_pcie_send_hcmd_sync(trans, cmd, cmd_str);

}