Commit ca077657 authored by Philipp Stanner's avatar Philipp Stanner Committed by Dave Airlie
Browse files

kernel: watch_queue: copy user-array safely 



Currently, there is no overflow-check with memdup_user().

Use the new function memdup_array_user() instead of memdup_user() for
duplicating the user-space array safely.

Suggested-by: default avatarDavid Airlie <airlied@redhat.com>
Signed-off-by: default avatarPhilipp Stanner <pstanner@redhat.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarZack Rusin <zackr@vmware.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920123612.16914-5-pstanner@redhat.com
parent 569c8d82

kernel/watch_queue.c

+1 −1
Original line number Diff line number Diff line
@@ -331,7 +331,7 @@ long watch_queue_set_filter(struct pipe_inode_info *pipe, 
	    filter.__reserved != 0)

		return -EINVAL;



	tf = memdup_user(_filter->filters, filter.nr_filters * sizeof(*tf));

	tf = memdup_array_user(_filter->filters, filter.nr_filters, sizeof(*tf));

	if (IS_ERR(tf))

		return PTR_ERR(tf);