Commit cb85c660 authored by Gabriele Monaco's avatar Gabriele Monaco Committed by Steven Rostedt (Google)
Browse files

rv: Add option for nested monitors and include sched 

Monitors describing complex systems, such as the scheduler, can easily
grow to the point where they are just hard to understand because of the
many possible state transitions.
Often it is possible to break such descriptions into smaller monitors,
sharing some or all events. Enabling those smaller monitors concurrently
is, in fact, testing the system as if we had one single larger monitor.
Splitting models into multiple specification is not only easier to
understand, but gives some more clues when we see errors.

Add the possibility to create container monitors, whose only purpose is
to host other nested monitors. Enabling a container monitor enables all
nested ones, but it's still possible to enable nested monitors
independently.
Add the sched monitor as first container, for now empty.

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Link: https://lore.kernel.org/20250305140406.350227-3-gmonaco@redhat.com


Signed-off-by: default avatarGabriele Monaco <gmonaco@redhat.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 26f80681

include/linux/rv.h

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ struct rv_monitor { 


bool rv_monitoring_on(void);

int rv_unregister_monitor(struct rv_monitor *monitor);

int rv_register_monitor(struct rv_monitor *monitor);

int rv_register_monitor(struct rv_monitor *monitor, struct rv_monitor *parent);

int rv_get_task_monitor_slot(void);

void rv_put_task_monitor_slot(int slot);

kernel/trace/rv/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ menuconfig RV 


source "kernel/trace/rv/monitors/wip/Kconfig"

source "kernel/trace/rv/monitors/wwnr/Kconfig"

source "kernel/trace/rv/monitors/sched/Kconfig"

# Add new monitors here



config RV_REACTORS

kernel/trace/rv/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ ccflags-y += -I $(src) # needed for trace events 
obj-$(CONFIG_RV) += rv.o

obj-$(CONFIG_RV_MON_WIP) += monitors/wip/wip.o

obj-$(CONFIG_RV_MON_WWNR) += monitors/wwnr/wwnr.o

obj-$(CONFIG_RV_MON_SCHED) += monitors/sched/sched.o

# Add new monitors here

obj-$(CONFIG_RV_REACTORS) += rv_reactors.o

obj-$(CONFIG_RV_REACT_PRINTK) += reactor_printk.o

kernel/trace/rv/monitors/sched/Kconfig

0 → 100644
+11 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

#

config RV_MON_SCHED

	depends on RV

	bool "sched monitor"

	help

	  Collection of monitors to check the scheduler behaves according to specifications.

	  Enable this to enable all scheduler specification supported by the current kernel.



	  For further information, see:

	    Documentation/trace/rv/monitor_sched.rst

kernel/trace/rv/monitors/sched/sched.c

0 → 100644
+38 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/init.h>

#include <linux/rv.h>



#define MODULE_NAME "sched"



#include "sched.h"



struct rv_monitor rv_sched;



struct rv_monitor rv_sched = {

	.name = "sched",

	.description = "container for several scheduler monitor specifications.",

	.enable = NULL,

	.disable = NULL,

	.reset = NULL,

	.enabled = 0,

};



static int __init register_sched(void)

{

	rv_register_monitor(&rv_sched, NULL);

	return 0;

}



static void __exit unregister_sched(void)

{

	rv_unregister_monitor(&rv_sched);

}



module_init(register_sched);

module_exit(unregister_sched);



MODULE_LICENSE("GPL");

MODULE_AUTHOR("Gabriele Monaco <gmonaco@redhat.com>");

MODULE_DESCRIPTION("sched: container for several scheduler monitor specifications.");