Commit cc4cce95 authored by Li Zhijian's avatar Li Zhijian Committed by Hans Verkuil
Browse files

media: imon: Convert sprintf/snprintf to sysfs_emit 



Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 8d93d067

drivers/media/rc/imon.c

+6 −6
Original line number Diff line number Diff line
@@ -845,9 +845,9 @@ static ssize_t imon_clock_show(struct device *d, 
	mutex_lock(&ictx->lock);



	if (!ictx->display_supported) {

		len = snprintf(buf, PAGE_SIZE, "Not supported.");

		len = sysfs_emit(buf, "Not supported.");

	} else {

		len = snprintf(buf, PAGE_SIZE,

		len = sysfs_emit(buf,

				 "To set the clock on your iMON display:\n"

				 "# date \"+%%y %%m %%d %%w %%H %%M %%S\" > imon_clock\n"

				 "%s", ictx->display_isopen ?