Commit cc9f07a8 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

r8169: fix WoL on shutdown if CONFIG_DEBUG_SHIRQ is set 



So far phy_disconnect() is called before free_irq(). If CONFIG_DEBUG_SHIRQ
is set and interrupt is shared, then free_irq() creates an "artificial"
interrupt by calling the interrupt handler. The "link change" flag is set
in the interrupt status register, causing phylib to eventually call
phy_suspend(). Because the net_device is detached from the PHY already,
the PHY driver can't recognize that WoL is configured and powers down the
PHY.

Fixes: f1e911d5 ("r8169: add basic phylib support")
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/fe732c2c-a473-9088-3974-df83cfbd6efd@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a11148e6

drivers/net/ethernet/realtek/r8169_main.c

+2 −2
Original line number Diff line number Diff line
@@ -4704,10 +4704,10 @@ static int rtl8169_close(struct net_device *dev) 


	cancel_work_sync(&tp->wk.work);



	phy_disconnect(tp->phydev);



	free_irq(pci_irq_vector(pdev, 0), tp);



	phy_disconnect(tp->phydev);



	dma_free_coherent(&pdev->dev, R8169_RX_RING_BYTES, tp->RxDescArray,

			  tp->RxPhyAddr);

	dma_free_coherent(&pdev->dev, R8169_TX_RING_BYTES, tp->TxDescArray,