Commit cd4897bf authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: st: add missing depopulate in probe error path 



Depopulate device in probe error paths to fix leak of children
resources.

Fixes: f83fca07 ("usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarPatrice Chotard <patrice.chotard@foss.st.com>
Acked-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240814093957.37940-2-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ddfcfeba

drivers/usb/dwc3/dwc3-st.c

+4 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ static int st_dwc3_probe(struct platform_device *pdev) 
	if (!child_pdev) {

		dev_err(dev, "failed to find dwc3 core device\n");

		ret = -ENODEV;

		goto err_node_put;

		goto depopulate;

	}



	dwc3_data->dr_mode = usb_get_dr_mode(&child_pdev->dev);
@@ -282,6 +282,7 @@ static int st_dwc3_probe(struct platform_device *pdev) 
	ret = st_dwc3_drd_init(dwc3_data);

	if (ret) {

		dev_err(dev, "drd initialisation failed\n");

		of_platform_depopulate(dev);

		goto undo_softreset;

	}
@@ -291,6 +292,8 @@ static int st_dwc3_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, dwc3_data);

	return 0;



depopulate:

	of_platform_depopulate(dev);

err_node_put:

	of_node_put(child);

undo_softreset: